Open
Conversation
Owner
|
I'm going to have to think about this one. I worry that it might cause too much divergence between Windows and non-Windows code. |
Author
|
I understand the need to consider for a bit - this took a fair bit of time for me to wrap my head around, and I'm certainly open to feedback if there are ways to make the contributions more streamlined. At least three of the commits cause no divergence between the two platforms, and using greg's cmake build particularly simplifies the build system independent of making the build simpler under Windows. The rest came from attempting to build MMD for inclusion in a python module, where the build can be fully automated in a python command (see here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes several steps to simplify the build of MultiMarkdown under windows, largely by removing dependencies that are not necessary for building. Specifically, this:
libgen.h, which are present in MINGW and POSIX, but not Windows. Instead, the Windows equivalent functions and definitions are used.strtok_sinstead ofstrtok_r, which fixes a potential buffer overflow bug in Windows.Using these changes, I'm able to build MultiMarkdown using the Visual Studio build system, without MINGW and Cygwin installed.